From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: He Kuang <hekuang@huawei.com>,
peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, wangnan0@huawei.com,
jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com,
namhyung@kernel.org, adrian.hunter@intel.com,
sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com,
tumanova@linux.vnet.ibm.com, kan.liang@intel.com,
penberg@kernel.org, dsahern@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 13/14] perf callchain: Support x86 target platform
Date: Wed, 1 Jun 2016 09:47:50 -0300 [thread overview]
Message-ID: <20160601124750.GO2563@kernel.org> (raw)
In-Reply-To: <20160601084015.GF13738@krava>
Em Wed, Jun 01, 2016 at 10:40:15AM +0200, Jiri Olsa escreveu:
> On Tue, May 31, 2016 at 11:19:11AM +0000, He Kuang wrote:
> SNIP
> > + ifeq ($(feature-libunwind-x86), 1)
> > + $(call detected,CONFIG_LIBUNWIND_X86)
> > + CFLAGS += -DHAVE_LIBUNWIND_X86_SUPPORT
> > + LDFLAGS += -lunwind-x86
> > + have_libunwind = 1
> > + endif
> > ifneq ($(feature-libunwind), 1)
> > msg := $(warning No libunwind found. Please install libunwind-dev[el] >= 1.1 and/or set LIBUNWIND_DIR);
> > NO_LOCAL_LIBUNWIND := 1
> > +++ b/tools/perf/util/Build
> > @@ -101,6 +101,7 @@ libperf-$(CONFIG_DWARF) += dwarf-aux.o
> > libperf-$(CONFIG_LIBDW_DWARF_UNWIND) += unwind-libdw.o
> > libperf-$(CONFIG_LOCAL_LIBUNWIND) += unwind-libunwind-local.o
> > libperf-$(CONFIG_LIBUNWIND) += unwind-libunwind.o
> > +libperf-$(CONFIG_LIBUNWIND_X86) += libunwind/x86_32.o
>
> seems odd but I dont have any better idea.. let's see what
> others have to say ;-)
There was a lot of discussion in this patchkit, so I lost track of why I
should consider the above odd :-)
I.e. I take the above as: if x86 libunwind was detected or explicitely
selected, link support for it when generating the perf tool in any
architecture, which seems sensible, no?
- Arnaldo
next prev parent reply other threads:[~2016-06-01 12:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 11:18 [PATCH v7 00/14] Add support for remote unwind He Kuang
2016-05-31 11:18 ` [PATCH v7 01/14] perf tools: Use LIBUNWIND_DIR for remote libunwind feature check He Kuang
2016-05-31 11:19 ` [PATCH v7 02/14] perf tools: Decouple thread->address_space on libunwind He Kuang
2016-05-31 11:19 ` [PATCH v7 03/14] perf tools: Introducing struct unwind_libunwind_ops for local unwind He Kuang
2016-06-01 8:39 ` Jiri Olsa
2016-06-01 8:39 ` Jiri Olsa
2016-05-31 11:19 ` [PATCH v7 04/14] perf tools: Move unwind__prepare_access from thread_new into thread__insert_map He Kuang
2016-06-01 8:39 ` Jiri Olsa
2016-05-31 11:19 ` [PATCH v7 05/14] perf tools: Don't mix LIBUNWIND_LIBS into LIBUNWIND_LDFLAGS He Kuang
2016-05-31 11:19 ` [PATCH v7 06/14] perf tools: Separate local/remote libunwind config He Kuang
2016-06-01 8:39 ` Jiri Olsa
2016-05-31 11:19 ` [PATCH v7 07/14] perf tools: Rename unwind-libunwind.c to unwind-libunwind-local.c He Kuang
2016-05-31 11:19 ` [PATCH v7 08/14] perf tools: Extract common API out of unwind-libunwind-local.c He Kuang
2016-05-31 11:19 ` [PATCH v7 09/14] perf tools: Export normalize_arch() function He Kuang
2016-05-31 11:19 ` [PATCH v7 10/14] perf tools: Check the target platform before assigning unwind methods He Kuang
2016-06-01 8:40 ` Jiri Olsa
2016-06-01 8:40 ` Jiri Olsa
2016-06-01 10:02 ` Hekuang
2016-05-31 11:19 ` [PATCH v7 11/14] perf tools: Change fixed name of libunwind__arch_reg_id to macro He Kuang
2016-05-31 11:19 ` [PATCH v7 12/14] perf tools: Introduce flag to separate local/remote unwind compilation He Kuang
2016-05-31 11:19 ` [PATCH v7 13/14] perf callchain: Support x86 target platform He Kuang
2016-06-01 8:40 ` Jiri Olsa
2016-06-01 12:47 ` Arnaldo Carvalho de Melo [this message]
2016-06-01 13:14 ` Jiri Olsa
2016-06-01 8:40 ` Jiri Olsa
2016-06-01 9:53 ` Hekuang
2016-06-01 8:41 ` Jiri Olsa
2016-05-31 11:19 ` [PATCH v7 14/14] perf callchain: Support aarch64 cross-platform He Kuang
2016-06-01 8:40 ` Jiri Olsa
2016-06-01 9:54 ` Hekuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601124750.GO2563@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=hekuang@huawei.com \
--cc=jolsa@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=sukadev@linux.vnet.ibm.com \
--cc=tumanova@linux.vnet.ibm.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox