From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758231AbcFAMr4 (ORCPT ); Wed, 1 Jun 2016 08:47:56 -0400 Received: from mail.kernel.org ([198.145.29.136]:50642 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750842AbcFAMry (ORCPT ); Wed, 1 Jun 2016 08:47:54 -0400 Date: Wed, 1 Jun 2016 09:47:50 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: He Kuang , peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 13/14] perf callchain: Support x86 target platform Message-ID: <20160601124750.GO2563@kernel.org> References: <1464693552-104294-1-git-send-email-hekuang@huawei.com> <1464693552-104294-14-git-send-email-hekuang@huawei.com> <20160601084015.GF13738@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160601084015.GF13738@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Jun 01, 2016 at 10:40:15AM +0200, Jiri Olsa escreveu: > On Tue, May 31, 2016 at 11:19:11AM +0000, He Kuang wrote: > SNIP > > + ifeq ($(feature-libunwind-x86), 1) > > + $(call detected,CONFIG_LIBUNWIND_X86) > > + CFLAGS += -DHAVE_LIBUNWIND_X86_SUPPORT > > + LDFLAGS += -lunwind-x86 > > + have_libunwind = 1 > > + endif > > ifneq ($(feature-libunwind), 1) > > msg := $(warning No libunwind found. Please install libunwind-dev[el] >= 1.1 and/or set LIBUNWIND_DIR); > > NO_LOCAL_LIBUNWIND := 1 > > +++ b/tools/perf/util/Build > > @@ -101,6 +101,7 @@ libperf-$(CONFIG_DWARF) += dwarf-aux.o > > libperf-$(CONFIG_LIBDW_DWARF_UNWIND) += unwind-libdw.o > > libperf-$(CONFIG_LOCAL_LIBUNWIND) += unwind-libunwind-local.o > > libperf-$(CONFIG_LIBUNWIND) += unwind-libunwind.o > > +libperf-$(CONFIG_LIBUNWIND_X86) += libunwind/x86_32.o > > seems odd but I dont have any better idea.. let's see what > others have to say ;-) There was a lot of discussion in this patchkit, so I lost track of why I should consider the above odd :-) I.e. I take the above as: if x86 libunwind was detected or explicitely selected, link support for it when generating the perf tool in any architecture, which seems sensible, no? - Arnaldo