From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751268AbcFASq6 (ORCPT ); Wed, 1 Jun 2016 14:46:58 -0400 Received: from mail-vk0-f67.google.com ([209.85.213.67]:34840 "EHLO mail-vk0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750744AbcFASq4 (ORCPT ); Wed, 1 Jun 2016 14:46:56 -0400 Date: Wed, 1 Jun 2016 14:46:54 -0400 From: Tejun Heo To: Bhaktipriya Shridhar Cc: "David S. Miller" , Akinobu Mita , Antonio Quartulli , Felipe Balbi , Florian Westphal , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: wiznet: Remove create_workqueue Message-ID: <20160601184654.GF14868@mtj.duckdns.org> References: <20160601175914.GA5169@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160601175914.GA5169@Karyakshetra> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 01, 2016 at 11:29:15PM +0530, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > A dedicated workqueue has been used since the workitems are involved > in normal device operation. Workitems &priv->rx_work and &priv->tx_work, > map to w5100_rx_work and w5100_tx_work respectively and are involved in > receiving and transmitting packets. Forward progress under > memory pressure is a requirement here. > > create_workqueue has been replaced with alloc_workqueue with max_active > as 0 since there is no need for throttling the number of active work > items. > > Since the driver may be used in memory reclaim path, > WQ_MEM_RECLAIM has been set to guarantee forward progress. > > flush_workqueue is unnecessary since destroy_workqueue() itself calls > drain_workqueue() which flushes repeatedly till the workqueue > becomes empty. Hence the call to flush_workqueue() has been dropped. > > Signed-off-by: Bhaktipriya Shridhar Acked-by: Tejun Heo Thanks. -- tejun