From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752877AbcFBCzw (ORCPT <rfc822;w@1wt.eu>);
	Wed, 1 Jun 2016 22:55:52 -0400
Received: from mga02.intel.com ([134.134.136.20]:65343 "EHLO mga02.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752730AbcFBCzu (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 1 Jun 2016 22:55:50 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,404,1459839600"; 
   d="scan'208";a="712569193"
Date: Thu, 2 Jun 2016 02:58:33 +0800
From: Yuyang Du <yuyang.du@intel.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Mike Galbraith <umgwanakikbuti@gmail.com>,
        Benjamin Segall <bsegall@google.com>, Paul Turner <pjt@google.com>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>
Subject: Re: [PATCH v3 4/5] sched/fair: Move load and util avgs from
 wake_up_new_task() to sched_fork()
Message-ID: <20160601185833.GW18670@intel.com>
References: <1464752466-3494-1-git-send-email-yuyang.du@intel.com>
 <1464752466-3494-5-git-send-email-yuyang.du@intel.com>
 <CAKfTPtAT3JaVdSQUHvknQWAmPMhndCy6ZVw92Esg-w2OCTGgtQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKfTPtAT3JaVdSQUHvknQWAmPMhndCy6ZVw92Esg-w2OCTGgtQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 01, 2016 at 02:24:29PM +0200, Vincent Guittot wrote:
> On 1 June 2016 at 05:41, Yuyang Du <yuyang.du@intel.com> wrote:
> > Move new task initialization to sched_fork(). For initial non-fair class
> > task, the first switched_to_fair() will do the attach correctly.
> 
> Not sure to catch the explanation. you have only moved and renamed
> init_entity_runnable_average but you speak about initial non-fair
> class

The non-fair class task mentioning is that I stopped a bit to figure
out whether only call sched_fork_fair(), but obviously sched classes
can change, so we should call sched_fork.

And this patch is ammeneable to the previous fix to switched_to().