From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751881AbcFAW1M (ORCPT ); Wed, 1 Jun 2016 18:27:12 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:57007 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750863AbcFAW1K (ORCPT ); Wed, 1 Jun 2016 18:27:10 -0400 Date: Thu, 2 Jun 2016 00:27:03 +0200 From: Andrew Lunn To: Mario Limonciello Cc: hayeswang@realtek.com, LKML , Netdev , Linux USB , pali.rohar@gmail.com, anthony.wong@canonical.com Subject: Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Message-ID: <20160601222703.GJ31982@lunn.ch> References: <1464817844-27206-1-git-send-email-mario_limonciello@dell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464817844-27206-1-git-send-email-mario_limonciello@dell.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 01, 2016 at 04:50:44PM -0500, Mario Limonciello wrote: > Dell systems with Type-C ports have support for a persistent system > specific MAC address when used with Dell Type-C docks and dongles. > This means a dock plugged into two different systems will show different > (but persistent) MAC addresses. Dell Type-C docks and dongles use the > r8152 driver. > > This information for the system's persistent MAC address is burned in when > the HW is built and avilable under _SB\AMAC in the DSDT at runtime. > > More information about the technology is available here: > http://www.dell.com/support/article/us/en/04/SLN301147 > > Signed-off-by: Mario Limonciello > --- > drivers/net/usb/Kconfig | 1 + > drivers/net/usb/r8152.c | 37 +++++++++++++++++++++++++++++++++++++ > 2 files changed, 38 insertions(+) > > diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig > index cdde590..c320930 100644 > --- a/drivers/net/usb/Kconfig > +++ b/drivers/net/usb/Kconfig > @@ -98,6 +98,7 @@ config USB_RTL8150 > config USB_RTL8152 > tristate "Realtek RTL8152/RTL8153 Based USB Ethernet Adapters" > select MII > + depends on ACPI Hi Mario That seems a bit heavy handed. What about ARM or MIPS machines which don't use ACPI but do have USB ports where i could plug in a USB dongle with this chipset. I think it would be better to make use of ACPI if it is available, but don't require it in order the build the driver. Andrew