Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address

Bjørn Mork
2016-06-02T18:04:24Z

<Mario_Limonciello@Dell.com> writes:

>> > 2) Track whether this is the first or second USB NIC plugged in. Only offer it
>> on the first NIC detected by r8152. When the second NIC is plugged in don't
>> match from ACPI.
>> > There would be a question of what to do if the first NIC is removed and
>> added back if it should get the persistent system MAC or not.
>> > I'd say yes, just make sure that only one NIC can have it at a time.
>>
>> You are going to get things very complex very quickly if you try to do this.
>
> It's really not that hard, track a module wide static variable whether
> the feature is in use. Track in each device whether the feature was
> in use. If it in use, don't assign the next device plugged in via the
> ACPI string. If a device is removed that has the feature activated,
> change the module wide static variable.

Having the mac address jump around in an arbitrary way like this is
going to confuse the hell out of your users. Consider what happens if
the user docks a laptop with an r8152 usb dongle already plugged in...
How are you going to explain that the dock gets some other mac address
in this case? How are you going to explain the difference between using
an r8152 based dongle and some other ethernet usb dongle with your
systems?

Make it behave consistently if you're going to add this. Which can be
done by specifically matching the Dell dock (doesn't it have an unique
Dell device ID?) and ignoring any other r8152 device. You could also
choose to set the same mac for all r8152 devices. Which is fine, but
will probably confuse many users.

What you definitely should not do is to change the mac for some
arbitrary "first" device. Then you are better off with the userspace
proposal where you and your users have some chance to implement a
sensible policy based on e.g. usb port numbers.

Bjørn