From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932380AbcFBIdi (ORCPT ); Thu, 2 Jun 2016 04:33:38 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:34093 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932188AbcFBIdh (ORCPT ); Thu, 2 Jun 2016 04:33:37 -0400 Date: Thu, 2 Jun 2016 10:33:30 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Weifeng Voon Cc: Wolfram Sang , Jarkko Nikula , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , jui.nee.tan@intel.com Subject: Re: [PATCH] i2c: designware: Enable ioctl I2C_TIMEOUT Message-ID: <20160602083330.GY26768@pengutronix.de> References: <1464854250-6810-1-git-send-email-weifeng.voon@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1464854250-6810-1-git-send-email-weifeng.voon@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 02, 2016 at 03:57:30PM +0800, Weifeng Voon wrote: > This allows applications to set the transfer timeout in 10ms increments via > ioctl I2C_TIMEOUT. 10ms is only correct with HZ=100. With higher values of HZ you get a finer resolution. I'd write: Respect the transfer timeout set via the I2C_TIMEOUT ioctl. and not mention the resolution at all. After all your patch doesn't "enable" that ioctl, just makes use of the value set by it. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |