From: Lee Jones <lee.jones@linaro.org>
To: p.zabel@pengutronix.de
Cc: linux-kernel@vger.kernel.org, hdegoede@redhat.com
Subject: Shared Resets
Date: Thu, 2 Jun 2016 11:12:59 +0100 [thread overview]
Message-ID: <20160602101259.GA1525@dell> (raw)
Philipp, Hans,
After rebasing to the most recent upstream kernel tag (v4.6-rc1), I
witnessed some issues where a couple of USB PHY drivers where having
trouble requesting their reset lines. After some poking around, I
stumbled across Hans' shared reset patch. It looks reasonable at
first, but when I came to make the necessary driver changes, I
realised that your effectively insisting that drivers have platform
specific knowledge.
The way I see it, drivers should request, deassert and assert their
reset lines. Just as clock users, request, enable and disable their
clocks. Whether the reset lines (or clocks) are left on after an
assert (disable) because there are other users, should be of no
concern to the consumer, right?
I would like to see (and am happy to author) a different approach,
where knowledge of whether a reset line is shared or not is contained
in the framework, as it is in the clock case.
What are your thoughts?
Kind regards,
Lee
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next reply other threads:[~2016-06-02 10:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 10:12 Lee Jones [this message]
2016-06-02 10:50 ` Shared Resets Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602101259.GA1525@dell \
--to=lee.jones@linaro.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox