From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753353AbcFBOTG (ORCPT ); Thu, 2 Jun 2016 10:19:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58095 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752365AbcFBOTD (ORCPT ); Thu, 2 Jun 2016 10:19:03 -0400 Date: Thu, 2 Jun 2016 16:18:58 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v2 0/2] KVM: x86: avoid simultaneous queueing of both IRQ and SMI Message-ID: <20160602141858.GB20275@potion> References: <1464812761-28709-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464812761-28709-1-git-send-email-pbonzini@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 02 Jun 2016 14:19:01 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-06-01 22:25+0200, Paolo Bonzini: > This was reported as a vmentry failure while running Windows with SMM > enabled. It's not that rare if your processor lacks APICv---it happens > about 20-30% of the time while installing Windows 10. > > I now understand the interrupt injection code (especially > complete_interrupts) better, and I also understand why the shortcut I took > in SMI handling was a bad idea. In the end the code is somewhat simpler > with the patch applied than before. > > The bug report is at https://github.com/tianocore/edk2/issues/91, but it > also fixes other Windows failures that Laszlo had reported to me privately. Applied, thanks.