From: Tejun Heo <tj@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch net-next 16/18] mlxsw: coRE: Add mlxsw specific workqueue and use it for FDB notif. processing
Date: Thu, 2 Jun 2016 10:37:03 -0400 [thread overview]
Message-ID: <20160602143703.GI14868@mtj.duckdns.org> (raw)
In-Reply-To: <20160602084106.GE1987@nanopsycho>
(cc'ing linux-kernel)
Hello,
On Thu, Jun 02, 2016 at 10:41:06AM +0200, Jiri Pirko wrote:
> Wed, Jun 01, 2016 at 09:42:34PM CEST, bhaktipriya96@gmail.com wrote:
> >Hi Jiri,
> >
> >I'm working on the workqueue project and I'm updating the legacy
> >workqueue interface users to use the new workqueue API.
> >
> >This patch uses create_workqueue which is deprecated and needs an
> >update.
> >
> >Your commit description says
> >"It makes sense to create separate workqueue just for mlxsw driver
> >in this case and do not pollute system_wq."
> >
> >I would like to inquire what "polluting system_wq" means.
>
> As the number of queued items is much bigger than originally expected, I
> wanted to have a separate wq for our driver. I believe it makes sense.
Unless it can queue a very large number of concurrent work items and
thus requires explicit concurrency limit, using a dedicated wq or not
doesn't make any difference. Sharing system_wq doesn't pollute it.
All workqueues share the same worker pools anyway.
Thanks.
--
tejun
parent reply other threads:[~2016-06-02 14:37 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20160602084106.GE1987@nanopsycho>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602143703.GI14868@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=bhaktipriya96@gmail.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).