From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932907AbcFBO5d (ORCPT ); Thu, 2 Jun 2016 10:57:33 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:36104 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932128AbcFBO5b (ORCPT ); Thu, 2 Jun 2016 10:57:31 -0400 Date: Thu, 2 Jun 2016 10:57:29 -0400 From: Tejun Heo To: Bhaktipriya Shridhar Cc: "David S. Miller" , Taku Izumi , Florian Westphal , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: fjes: fjes_main: Remove create_workqueue Message-ID: <20160602145729.GO14868@mtj.duckdns.org> References: <20160602093057.GA15351@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160602093057.GA15351@Karyakshetra> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 02, 2016 at 03:00:57PM +0530, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > The workqueue adapter->txrx_wq has workitem > &adapter->raise_intr_rxdata_task per adapter. Extended Socket Network > Device is shared memory based, so someone's transmission denotes other's > reception. raise_intr_rxdata_task raises interruption of receivers from > the sender in order to notify receivers. > > The workqueue adapter->control_wq has workitem > &adapter->interrupt_watch_task per adapter. interrupt_watch_task is used > to prevent delay of interrupts. > > Dedicated workqueues have been used in both cases since the workitems > on the workqueues are involved in normal device operation and require > forward progress under memory pressure. > > max_active has been set to 0 since there is no need for throttling > the number of active work items. > > Since network devices may be used for memory reclaim, > WQ_MEM_RECLAIM has been set to guarantee forward progress. Patch looks good but ditto with the description. I wish it were clearer. Thanks. -- tejun