From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753500AbcFBQaM (ORCPT <rfc822;w@1wt.eu>);
	Thu, 2 Jun 2016 12:30:12 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:41432 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753316AbcFBQaK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 2 Jun 2016 12:30:10 -0400
Date: Thu, 2 Jun 2016 17:29:56 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>, lkp@01.org,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [LKP] [lkp] [dcache_{readdir, dir_lseek}() users] 4e82901cd6:
 reaim.jobs_per_min -49.1% regression
Message-ID: <20160602162956.GH14480@ZenIV.linux.org.uk>
References: <20160531081515.GC11635@yexl-desktop>
 <20160531134011.GB14480@ZenIV.linux.org.uk>
 <87bn3laffo.fsf@yhuang-dev.intel.com>
 <87h9dchzor.fsf@yhuang-dev.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87h9dchzor.fsf@yhuang-dev.intel.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 02, 2016 at 02:28:36PM +0800, Huang, Ying wrote:
> "Huang, Ying" <ying.huang@intel.com> writes:

> Here is the comparison result with perf profile information.  You can
> find it via searching 'perf-profile'.
[snip]

Looks like this load is hitting the arseloads of contention cases of
spin_lock() on various ->d_lock inside dcache_readdir().  With exclusive
lock on directory most of them end up uncontended...

I'll try to see what can be done there; quite a bit of those are actually
due to moving the cursor on every step.  I wonder if we could do the list
traversals with something less drastic - the real contents changes are
prevented by the shared lock on directory being held, after all...

I'll play with that and post when I get somewhere with it...