From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932736AbcFBUeJ (ORCPT ); Thu, 2 Jun 2016 16:34:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46846 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932171AbcFBUeG (ORCPT ); Thu, 2 Jun 2016 16:34:06 -0400 Date: Thu, 2 Jun 2016 22:33:54 +0200 From: Jiri Olsa To: He Kuang Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 04/14] perf tools: Move unwind__prepare_access from thread_new into thread__insert_map Message-ID: <20160602203354.GA26647@krava> References: <1464861326-22677-1-git-send-email-hekuang@huawei.com> <1464861326-22677-5-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464861326-22677-5-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 02 Jun 2016 20:34:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 02, 2016 at 09:55:16AM +0000, He Kuang wrote: SNIP > } > > -void thread__insert_map(struct thread *thread, struct map *map) > +int thread__insert_map(struct thread *thread, struct map *map) > { > + int ret; > + > map_groups__fixup_overlappings(thread->mg, map, stderr); > map_groups__insert(thread->mg, map); > + > + ret = unwind__prepare_access(thread); > + if (ret) > + map_groups__remove(thread->mg, map); we could move this call to the top and sve the call to map_groups__remove jirka