From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933049AbcFBUfR (ORCPT ); Thu, 2 Jun 2016 16:35:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39496 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932993AbcFBUfP (ORCPT ); Thu, 2 Jun 2016 16:35:15 -0400 Date: Thu, 2 Jun 2016 22:35:04 +0200 From: Jiri Olsa To: He Kuang Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 00/14] Add support for remote unwind Message-ID: <20160602203504.GE26647@krava> References: <1464861326-22677-1-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464861326-22677-1-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 02 Jun 2016 20:35:14 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 02, 2016 at 09:55:12AM +0000, He Kuang wrote: SNIP > and now we can use LIBUNWIND_DIR to specific custom dirctories > containing libunwind libs. > > v8: > > - Put unwind__register_ops call into unwind__prepare_access from > patch 4 to patch 3. > - Fail thread__insert_map on error. > - Remove unused macro HAVE_LIBUNWIND_LOCAL_SUPPORT. > - Return once find that thread->addr_space is valid and check this > value first. > - Add comments in file 'util/libunwind/arm64.c', > 'util/libunwind/x86_32.c', and explain the reason for debug-frame > flag in non-arm arch. apart from few nitpicks, this looks ok to me I tried with 32bit unwind under 64bits and it works nicely, plus 64bit unwind seems not to be broken as well ;-) considerring those nitpicks solved: Acked-by: Jiri Olsa thanks, jirka