From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932843AbcFCQvo (ORCPT ); Fri, 3 Jun 2016 12:51:44 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:50440 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932822AbcFCQvm (ORCPT ); Fri, 3 Jun 2016 12:51:42 -0400 Date: Fri, 3 Jun 2016 18:50:55 +0200 From: Pavel Machek To: Eric Blake , mpa@pengutronix.de Cc: Pranay Srivastava , Greg KH , nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [Nbd] Fwd: [PATCH v4 02/18] nbd: fix checkpatch trailing space warning. Message-ID: <20160603165055.GA11253@amd> References: <1462954726-11825-1-git-send-email-pranjas@gmail.com> <1462954726-11825-3-git-send-email-pranjas@gmail.com> <20160511083331.GA29268@kroah.com> <573337B1.6030900@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <573337B1.6030900@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2016-05-11 07:46:25, Eric Blake wrote: > On 05/11/2016 03:38 AM, Pranay Srivastava wrote: > > > > > The series contained some checkpatch changes so I had included you as well. > > > >> know why you are sending them to me), but I know I do not accept patches > >> without any changelog text at all in them, as that's just lazy. > > > > That should be per patch or can appear in a cover letter for the patches? > > Per patch. However, if it were me, I would not have split into quite so > many patches. The mantra is one patch per one fix, but I think it is > reasonable to state that "silence all checkpatch warnings" counts as one > fix, rather than 16 separate fixes. If you DO consolidate the > checkpatch changes into a single patch, then the commit message body > should call out a bulleted list of all the changes you are making, as > well as a justification why it is worth churning the entire file rather > than just making smaller checkpatch fixes in just the areas that your > other patches touch. Unfortunately, Greg told him to split it like this. I also liked the single patch more. I wonder why mpa@pengutronix.de was not cc-ed on this series? Anyway, the cleanups are so trivial they should just be applied.... No need to spend huge time arguing. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html