From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932582AbcFCRg7 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 3 Jun 2016 13:36:59 -0400
Received: from mail.kernel.org ([198.145.29.136]:51638 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932119AbcFCRg4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 3 Jun 2016 13:36:56 -0400
Date: Fri, 3 Jun 2016 10:36:54 -0700
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: Chao Yu <chao@kernel.org>, linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: fix to redirty page if fail to gc data page
Message-ID: <20160603173654.GA29066@jaegeuk>
References: <1463807951-10472-1-git-send-email-chao@kernel.org>
 <20160530023702.GB78763@jaegeuk.hsd1.ca.comcast.net>
 <a09543b8-349e-d2cc-0e15-f2bf82d4dcfa@huawei.com>
 <20160603050858.GA24882@jaegeuk>
 <d0222ec2-986a-9d73-d3f5-c98335c0f37a@huawei.com>
 <20160603051734.GA25068@jaegeuk>
 <e0ec235d-67ac-751f-a343-f227525fd19b@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e0ec235d-67ac-751f-a343-f227525fd19b@huawei.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 03, 2016 at 01:59:15PM +0800, Chao Yu wrote:
...

> >>> Do we have another expectation?
> >>
> >> ENOMEM or EIO?
> > 
> > EIO will stop everything.
> > ENOMEM would be better to wait for a while from page reclaim?
> 
> Agree, but for ioctl path, IMO, we don't need to let user waiting for ENOMEM
> case looping.

Well, if user wanted to do a synchronous gc, we need that, IMO.