From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751262AbcFDAEA (ORCPT ); Fri, 3 Jun 2016 20:04:00 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59341 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195AbcFDAD5 (ORCPT ); Fri, 3 Jun 2016 20:03:57 -0400 Date: Fri, 3 Jun 2016 17:03:55 -0700 From: Stephen Boyd To: Bjorn Andersson Cc: Andy Gross , David Brown , Greg Kroah-Hartman , Jiri Slaby , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Frank Rowand , Nicolas Dechesne , Ivan Ivanov , stable@vger.kernel.org Subject: Re: [PATCH] tty: serial: msm: Don't read off end of tx fifo Message-ID: <20160604000355.GX28218@codeaurora.org> References: <1464914908-19059-1-git-send-email-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464914908-19059-1-git-send-email-bjorn.andersson@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/02, Bjorn Andersson wrote: > For dm uarts in pio mode tx data is transferred to the fifo register 4 > bytes at a time, but care is not taken when these 4 bytes spans the end > of the xmit buffer so the loop might read up to 3 bytes past the buffer > and then skip the actual data at the beginning of the buffer. > > Fix this by, analogous to the DMA case, make sure the chunk doesn't > wrap the xmit buffer. > > Fixes: 3a878c430fd6 ("tty: serial: msm: Add TX DMA support") > Cc: Andy Gross > Cc: Ivan Ivanov > Cc: Stephen Boyd > Cc: stable@vger.kernel.org > Reported-by: Frank Rowand > Reported-by: Nicolas Dechesne > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project