From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750972AbcFDN1v (ORCPT ); Sat, 4 Jun 2016 09:27:51 -0400 Received: from down.free-electrons.com ([37.187.137.238]:49195 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750838AbcFDN1t (ORCPT ); Sat, 4 Jun 2016 09:27:49 -0400 Date: Sat, 4 Jun 2016 15:27:47 +0200 From: Alexandre Belloni To: Colin King Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: interface: ignore exprired timers one enqueing new timers Message-ID: <20160604132747.GI4594@piout.net> References: <1463415774-28014-1-git-send-email-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463415774-28014-1-git-send-email-colin.king@canonical.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/05/2016 at 17:22:54 +0100, Colin King wrote : > From: Colin Ian King > > This patch fixes a RTC wakealarm issue, namely, the event fires during > hibernate and is not cleared from the list, causing hwclock to block. > > The current enqueuing does not trigger an alarm if any expired timers > already exist on the timerqueue. This can occur when a RTC wake alarm > is used to wake a machine out of hibernate and the resumed state has > old expired timers that have not been removed from the timer queue. > This fix skips over any expired timers and triggers an alarm if there > are no pending timers on the timerqueue. Note that the skipped expired > timer will get repead later on, so there is no need to clean it up > immediately. > > The issue can be reproduced by putting a machine into hibernate and > waking it with the RTC wakealarm. Running the example RTC test program > from tools/testing/selftests/timers/rtctest.c after the hibernate will > block indefinitely. With the fix, it no longer blocks after the > hibernate resume. > > BugLink: http://bugs.launchpad.net/bugs/1333569 > > Signed-off-by: Colin Ian King > --- > drivers/rtc/interface.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com