From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Joshua Kinard <kumba@gentoo.org>,
Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] rtc: ds1685: correct check of day of month
Date: Sat, 4 Jun 2016 15:46:55 +0200 [thread overview]
Message-ID: <20160604134655.GJ4594@piout.net> (raw)
In-Reply-To: <1463869135-32575-1-git-send-email-xypron.glpk@gmx.de>
On 22/05/2016 at 00:18:55 +0200, Heinrich Schuchardt wrote :
> The day of month is checked in ds1685_rtc_read_alarm
> and ds1685_rtc_set_alarm.
>
> Multiple errors exist in the day of month check.
>
> Operator ! has a higher priority than &&.
> (!(mday >= 1) && (mday <= 31)) is false for mday == 32.
>
> When verifying the day of month the binary and the BCD mode
> have to be considered.
>
> v2:
> consider ds1685_rtc_read_alarm
> consider rtc->bcd_mode as indicated by Alexandre Belloni
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> drivers/rtc/rtc-ds1685.c | 34 +++++++++++++++++++++++++++++-----
> 1 file changed, 29 insertions(+), 5 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-06-04 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 19:09 [PATCH 1/1] rtc: ds1685: correct check of day of month Heinrich Schuchardt
2016-05-20 22:38 ` Alexandre Belloni
2016-05-21 22:18 ` [PATCH v2 " Heinrich Schuchardt
2016-06-04 13:46 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160604134655.GJ4594@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=kumba@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox