From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751227AbcFDOHw (ORCPT ); Sat, 4 Jun 2016 10:07:52 -0400 Received: from down.free-electrons.com ([37.187.137.238]:49507 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750889AbcFDOHu (ORCPT ); Sat, 4 Jun 2016 10:07:50 -0400 Date: Sat, 4 Jun 2016 16:07:48 +0200 From: Alexandre Belloni To: venkat.prashanth2498@gmail.com Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, k.kozlowski@samsung.com, marcus.folkesson@gmail.com Subject: Re: [PATCH v4] rtc:add support for maxim rtc max6916 Message-ID: <20160604140748.GL4594@piout.net> References: <1464762594-2336-1-git-send-email-venkat.prashanth2498@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464762594-2336-1-git-send-email-venkat.prashanth2498@gmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/2016 at 11:59:54 +0530, venkat.prashanth2498@gmail.com wrote : > From: VENKAT PRASHANTH B U > > This is a patch to add support for > maxim rtc max6916 > > Signed-off-by: Venkat Prashanth B U > --- > changelog v4: > - fixed the line wrapping to around 72 characters > - Aligned the values with tabs > - inserted the correct coding style in the conditional statements > - removed the empty lines towards the end of the code > - fixed the checkpatch issues > - code clean up on max6916_read_reg() > > changelog v3: > - saperated the logical code sections with an empty line > - used indentations after if statements. > - fixed the out of tree makefile > - placed the test condition at the begining of the function > > change log v2: > - deleted the port i/o's > - clock burst value is modified from 0x00 to 0x3F > - The time in linux is in binary format so get_rtc()replaced with bcd2bin() > - enforced the year range instead of accepting any value > --- > --- > drivers/rtc/Kconfig | 12 ++++ > drivers/rtc/Makefile | 1 + > drivers/rtc/rtc-max6916.c | 167 ++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 180 insertions(+) > I've applied it but you probably edited the diff by hand so I had to edit it a bit more to get it to apply correctly. Also, I fixed the remaining checkpatch issues. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com