From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751183AbcFDQgn (ORCPT ); Sat, 4 Jun 2016 12:36:43 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60402 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbcFDQgl (ORCPT ); Sat, 4 Jun 2016 12:36:41 -0400 Date: Sat, 4 Jun 2016 09:36:40 -0700 From: Greg KH To: Jyoti Singh Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, Jyoti Singh Subject: Re: [PATCH] char: Prefer pr_* instead of printk Message-ID: <20160604163640.GA6559@kroah.com> References: <1465051511-10758-1-git-send-email-jssengar92@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465051511-10758-1-git-send-email-jssengar92@gmail.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 04, 2016 at 08:15:11PM +0530, Jyoti Singh wrote: > This patch replaces all the printk[KERN_INFO] with pr_* in the file > "ttyprintk.c" addressing the following warning: > > WARNING:Prefer [subsystem eg: netdev]_info([subsystem]dev, ... > then dev_info(dev,... then pr_info(... to printk(KERN_INFO ... > Found with checkpatch Sometimes checkpatch tells you to do things that are incorrect :) Are you _sure_ the code works the same before and after this? The ttyprintk driver is a bit "special". Did you test these changes? thanks, greg k-h