From: Pavel Machek <pavel@ucw.cz>
To: changbin.du@intel.com
Cc: balbi@kernel.org, gregkh@linuxfoundation.org, corbet@lwn.net,
linux-usb@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, "Du,
Changbin" <changbin.du@gmail.com>,
Du@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as binding to *any* UDC
Date: Sat, 4 Jun 2016 22:56:11 +0200 [thread overview]
Message-ID: <20160604205611.GA29877@amd> (raw)
In-Reply-To: <1462244665-27681-2-git-send-email-changbin.du@intel.com>
On Tue 2016-05-03 11:04:24, changbin.du@intel.com wrote:
> From: "Du, Changbin" <changbin.du@gmail.com>
>
> On most platforms, there is only one device controller available.
> In this case, we desn't care the UDC's name. So let's ignore the
> name by setting 'UDC' to 'any'. And also we can change UDC name
> at any time if it is not binded (no need set to "" first).
making "any" special does not look like a good idea. What if it really
is "any"?
Return nothing instead, not even \n?
> Signed-off-by: Du, Changbin <changbin.du@gmail.com>
> Signed-off-by: Du, Changbin <changbin.du@intel.com>
I don't think this is how you should sign it off.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2016-06-04 20:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 3:04 [PATCH 0/2] Add binding rule *any* support for USB Gadget Configfs changbin.du
2016-05-03 3:04 ` [PATCH 1/2] usb: configfs: allow UDC binding rule configured as binding to *any* UDC changbin.du
2016-05-04 8:14 ` Krzysztof Opasiak
2016-05-05 5:46 ` Du, Changbin
2016-05-05 7:31 ` Krzysztof Opasiak
2016-05-06 2:46 ` Du, Changbin
2016-05-06 5:49 ` Krzysztof Opasiak
2016-06-04 20:56 ` Pavel Machek [this message]
2016-06-06 2:21 ` Du, Changbin
2016-05-03 3:04 ` [PATCH 2/2] Documentation: gadget_configfs: update UDC binding changbin.du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160604205611.GA29877@amd \
--to=pavel@ucw.cz \
--cc=Du@vger.kernel.org \
--cc=balbi@kernel.org \
--cc=changbin.du@gmail.com \
--cc=changbin.du@intel.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox