From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751570AbcFDU4T (ORCPT ); Sat, 4 Jun 2016 16:56:19 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:51631 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750833AbcFDU4Q (ORCPT ); Sat, 4 Jun 2016 16:56:16 -0400 Date: Sat, 4 Jun 2016 22:56:11 +0200 From: Pavel Machek To: changbin.du@intel.com Cc: balbi@kernel.org, gregkh@linuxfoundation.org, corbet@lwn.net, linux-usb@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, "Du, Changbin" , Du@vger.kernel.org Subject: Re: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as binding to *any* UDC Message-ID: <20160604205611.GA29877@amd> References: <1462244665-27681-1-git-send-email-changbin.du@intel.com> <1462244665-27681-2-git-send-email-changbin.du@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462244665-27681-2-git-send-email-changbin.du@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2016-05-03 11:04:24, changbin.du@intel.com wrote: > From: "Du, Changbin" > > On most platforms, there is only one device controller available. > In this case, we desn't care the UDC's name. So let's ignore the > name by setting 'UDC' to 'any'. And also we can change UDC name > at any time if it is not binded (no need set to "" first). making "any" special does not look like a good idea. What if it really is "any"? Return nothing instead, not even \n? > Signed-off-by: Du, Changbin > Signed-off-by: Du, Changbin I don't think this is how you should sign it off. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html