From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751632AbcFEO4q (ORCPT ); Sun, 5 Jun 2016 10:56:46 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:59883 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954AbcFEO4o (ORCPT ); Sun, 5 Jun 2016 10:56:44 -0400 Date: Sun, 5 Jun 2016 16:56:32 +0200 From: Andrew Lunn To: John Crispin Cc: "David S. Miller" , Felix Fietkau , Sean Wang , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/12] net: mediatek: increase watchdog_timeo Message-ID: <20160605145632.GI12165@lunn.ch> References: <1465108385-38286-1-git-send-email-john@phrozen.org> <1465108385-38286-10-git-send-email-john@phrozen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465108385-38286-10-git-send-email-john@phrozen.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 05, 2016 at 08:33:02AM +0200, John Crispin wrote: > During stress testing, after reducing the threshold value, we have seen > TX timeouts that were caused by the watchdog_timeo value being too low. > Increase the value to 5 * HZ which is a value commonly used by many other > drivers. I've never studied what watchdog_timeo actually means. Does it mean a transmit has not completed in that amount of time? Would this imply you have 5 seconds worth of packets in your transmit queue? Do you know what the driver is doing during this 5 seconds? Thanks Andrew