Re: [PATCH 4.6 000/121] 4.6.2-stable review

Greg Kroah-Hartman
2016-06-06T23:33:17Z

On Mon, Jun 06, 2016 at 06:43:47PM -0400, Javier Martinez Canillas wrote:
> Hello,
>
> On 06/06/2016 06:32 PM, Tyler Baker wrote:
> > On 6 June 2016 at 06:55, Kevin Hilman <khilman@baylibre.com> wrote:
> >> kernelci.org bot <bot@kernelci.org> writes:
> >>
> >>> stable-queue boot: 73 boots: 3 failed, 68 passed with 2 offline (v4.6.1-121-g2276ff7d4bf9)
> >>>
> >>> Full Boot Summary: https://kernelci.org/boot/all/job/stable-queue/kernel/v4.6.1-121-g2276ff7d4bf9/
> >>> Full Build Summary: https://kernelci.org/build/stable-queue/kernel/v4.6.1-121-g2276ff7d4bf9/
> >>>
> >>> Tree: stable-queue
> >>> Branch: local/linux-4.6.y.queue
> >>> Git Describe: v4.6.1-121-g2276ff7d4bf9
> >>> Git Commit: 2276ff7d4bf9c438832f761ffd525cacf55362cd
> >>> Git URL: git://server.roeck-us.net/git/linux-stable.git
> >>> Tested: 28 unique boards, 9 SoC families, 16 builds out of 100
> >>>
> >>> Boot Failures Detected: https://kernelci.org/boot/?v4.6.1-121-g2276ff7d4bf9&fail
> >>>
> >>> arm64:
> >>>
> >>> defconfig:
> >>> apq8016-sbc: 1 failed lab
> >>>
> >>> defconfig+CONFIG_RANDOMIZE_BASE=y:
> >>> apq8016-sbc: 1 failed lab
> >>
> >> Theses two are real boot regressions, bisections forthcoming.
> >
> > I have bisected[1] these two failures down to 5e3ca2b349b1
> > ("regulator: Try to resolve regulators supplies on registration") and
> > confirmed that reverting this patch on top of this stable queue fixes
> > the boot issue.
> >
> > Adding Mark B. and Javier C. to this thread for discussion.
> >
>
> I'm not familiar with the apq8016-sbc board or Qualcomm platforms in general
> but this patch is known to cause deadlocks when looking up regulators that
> were not registered via OF. This was an issue on at least some Nvidia boards.
>
> So since this patch made it to stable, commit a21513742308 ("regulator: Fix
> deadlock during regulator registration") [0] should also be included.

Ugh. Why wasn't that patch also marked for stable inclusion? This was
a problem waiting to happen that could have been totally avoided :(

I'll queue it up this evening, thanks.

greg k-h