From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752643AbcFFERH (ORCPT ); Mon, 6 Jun 2016 00:17:07 -0400 Received: from mga02.intel.com ([134.134.136.20]:30811 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750743AbcFFERF (ORCPT ); Mon, 6 Jun 2016 00:17:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,425,1459839600"; d="scan'208";a="714472356" Date: Mon, 6 Jun 2016 09:53:38 +0530 From: Vinod Koul To: Eric Anholt Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stephen Warren , Lee Jones , dmaengine@vger.kernel.org Subject: Re: [PATCH] dma: bcm2835: Fix compiler warning on arm64. Message-ID: <20160606042337.GT16910@localhost> References: <1465007013-5300-1-git-send-email-eric@anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465007013-5300-1-git-send-email-eric@anholt.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 03, 2016 at 07:23:33PM -0700, Eric Anholt wrote: > The min() macro was complaining about mismatched types. The max len > is at most SZ_1G, so we can just put it in an unsigned int. > > Signed-off-by: Eric Anholt > --- > > Vinod, if you ack it, this one would be nice to be able to merge > through the -soc tree, so that when we enable of arm64 builds of this > driver we don't introduce a new compiler warning. > > drivers/dma/bcm2835-dma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c > index 6149b27c33ad..1fa11fc067c6 100644 > --- a/drivers/dma/bcm2835-dma.c > +++ b/drivers/dma/bcm2835-dma.c > @@ -393,7 +393,7 @@ static void bcm2835_dma_fill_cb_chain_with_sg( > unsigned int sg_len) > { > struct bcm2835_chan *c = to_bcm2835_dma_chan(chan); > - size_t max_len = bcm2835_dma_max_frame_length(c); > + unsigned int max_len = bcm2835_dma_max_frame_length(c); bcm2835_dma_max_frame_length() returns size_t. so this should also add a complain about type mismatch as well! Also, wouldn't it be better to make both args of min() as size_t then? > unsigned int i, len; > dma_addr_t addr; > struct scatterlist *sgent; > -- > 2.8.0.rc3 > Thanks -- ~Vinod