* [PATCH 1/1 linux-next] ASoC: cs53l30: include gpio/consumer.h
@ 2016-06-05 13:11 Fabian Frederick
2016-06-06 5:06 ` Nicolin Chen
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2016-06-05 13:11 UTC (permalink / raw)
To: Nicolin Chen; +Cc: alsa-devel, linux-kernel, fabf
cs53l30 breaks kernel compilation when CONFIG_GPIOLIB is disabled.
sound/soc/codecs/cs53l30.c:931:2: error: implicit declaration of
function devm_gpiod_get_optional [-Werror=implicit-function-declaration]
cs53l30->reset_gpio = devm_gpiod_get_optional(dev, "reset",
^
sound/soc/codecs/cs53l30.c:932:13: error: GPIOD_OUT_LOW undeclared
(first use in this function)
Including gpio/consumer.h declares minimal functions in that case.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
sound/soc/codecs/cs53l30.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
index ac90dd7..4818324 100644
--- a/sound/soc/codecs/cs53l30.c
+++ b/sound/soc/codecs/cs53l30.c
@@ -15,6 +15,7 @@
#include <linux/clk.h>
#include <linux/delay.h>
#include <linux/i2c.h>
+#include <linux/gpio/consumer.h>
#include <linux/module.h>
#include <linux/of_gpio.h>
#include <linux/regulator/consumer.h>
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1 linux-next] ASoC: cs53l30: include gpio/consumer.h
2016-06-05 13:11 [PATCH 1/1 linux-next] ASoC: cs53l30: include gpio/consumer.h Fabian Frederick
@ 2016-06-06 5:06 ` Nicolin Chen
0 siblings, 0 replies; 2+ messages in thread
From: Nicolin Chen @ 2016-06-06 5:06 UTC (permalink / raw)
To: Fabian Frederick; +Cc: alsa-devel, linux-kernel
On Sun, Jun 05, 2016 at 03:11:00PM +0200, Fabian Frederick wrote:
> cs53l30 breaks kernel compilation when CONFIG_GPIOLIB is disabled.
>
> sound/soc/codecs/cs53l30.c:931:2: error: implicit declaration of
> function devm_gpiod_get_optional [-Werror=implicit-function-declaration]
> cs53l30->reset_gpio = devm_gpiod_get_optional(dev, "reset",
> ^
> sound/soc/codecs/cs53l30.c:932:13: error: GPIOD_OUT_LOW undeclared
> (first use in this function)
>
> Including gpio/consumer.h declares minimal functions in that case.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> sound/soc/codecs/cs53l30.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
> index ac90dd7..4818324 100644
> --- a/sound/soc/codecs/cs53l30.c
> +++ b/sound/soc/codecs/cs53l30.c
> @@ -15,6 +15,7 @@
> #include <linux/clk.h>
> #include <linux/delay.h>
> #include <linux/i2c.h>
> +#include <linux/gpio/consumer.h>
Could you put it before i2c.h to order them alphabetically?
Thank you
> #include <linux/module.h>
> #include <linux/of_gpio.h>
> #include <linux/regulator/consumer.h>
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-06 5:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-05 13:11 [PATCH 1/1 linux-next] ASoC: cs53l30: include gpio/consumer.h Fabian Frederick
2016-06-06 5:06 ` Nicolin Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox