From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751193AbcFFJAG (ORCPT ); Mon, 6 Jun 2016 05:00:06 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:37248 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750956AbcFFJAD (ORCPT ); Mon, 6 Jun 2016 05:00:03 -0400 Date: Mon, 6 Jun 2016 10:00:33 +0100 From: Lee Jones To: Keerthy Cc: Keerthy , broonie@kernel.org, tony@atomide.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nikita@compulab.co.il, nm@ti.com Subject: Re: [PATCH 3/8] mfd: tps65218: Use mfd_add_devices instead of of_platform_populate Message-ID: <20160606090033.GC1525@dell> References: <1462945691-904-1-git-send-email-j-keerthy@ti.com> <1462945691-904-4-git-send-email-j-keerthy@ti.com> <57516549.6040102@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <57516549.6040102@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 03 Jun 2016, Keerthy wrote: > Hi Lee Jones, > > On Wednesday 11 May 2016 11:18 AM, Keerthy wrote: > >mfd_add_devices enables parsing device tree nodes without compatibles > >for child nodes. Replace of_platform_populate with mfd_add_devices. > > > > A gentle ping on this patch. Don't do that! If you think it's forgotten then send a [RESEND]. However this patch is in my "to review" queue and will be dealt with in due course. > >Signed-off-by: Keerthy > >--- > > drivers/mfd/tps65218.c | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > >diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c > >index f20a531..b8b3a58 100644 > >--- a/drivers/mfd/tps65218.c > >+++ b/drivers/mfd/tps65218.c > >@@ -33,6 +33,10 @@ > > > > #define TPS65218_PASSWORD_REGS_UNLOCK 0x7D > > > >+static const struct mfd_cell tps65218_cells[] = { > >+ { .name = "tps65218-regulator", }, > >+}; > >+ > > /** > > * tps65218_reg_write: Write a single tps65218 register. > > * > >@@ -236,8 +240,10 @@ static int tps65218_probe(struct i2c_client *client, > > if (ret < 0) > > return ret; > > > >- ret = of_platform_populate(client->dev.of_node, NULL, NULL, > >- &client->dev); > >+ ret = mfd_add_devices(tps->dev, PLATFORM_DEVID_AUTO, tps65218_cells, > >+ ARRAY_SIZE(tps65218_cells), NULL, 0, > >+ regmap_irq_get_domain(tps->irq_data)); > >+ > > if (ret < 0) > > goto err_irq; > > > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog