From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751568AbcFFKQw (ORCPT ); Mon, 6 Jun 2016 06:16:52 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:32843 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750933AbcFFKQv (ORCPT ); Mon, 6 Jun 2016 06:16:51 -0400 Date: Mon, 6 Jun 2016 12:16:47 +0200 From: Pavel Machek To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Vinod Koul , Jon Hunter , linux-pm@vger.kernel.org Subject: Re: [PATCH] PM / clk: export symbols for existing pm_clk_<...> API fcns Message-ID: <20160606101647.GA22028@amd> References: <1465149495-22961-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465149495-22961-1-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 2016-06-05 13:58:15, Paul Gortmaker wrote: > While trying to convert a DMA driver from bool to tristate, we > encountered the following: > > ERROR: "pm_clk_add_clk" [drivers/dma/tegra210-adma.ko] undefined! > ERROR: "pm_clk_create" [drivers/dma/tegra210-adma.ko] undefined! > ERROR: "pm_clk_destroy" [drivers/dma/tegra210-adma.ko] undefined! > ERROR: "pm_clk_suspend" [drivers/dma/tegra210-adma.ko] undefined! > ERROR: "pm_clk_resume" [drivers/dma/tegra210-adma.ko] undefined! > > Since in principle there is nothing preventing these functions > from being used in modular code as well as builtin, we add the > export of them. We expand the scope to also include: > > pm_clk_add > of_pm_clk_add_clks > pm_clk_remove > pm_clk_remove_clk > pm_clk_init > pm_clk_runtime_suspend > pm_clk_runtime_resume > pm_clk_add_notifier > > ...since these functions are also non-static and presumably form > part of the existing API used by other drivers that may become > modular in the future. > > Cc: "Rafael J. Wysocki" Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html