From: Leon Romanovsky <leon@kernel.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH 2/2] IB/sysfs: fix memory leak
Date: Mon, 6 Jun 2016 15:17:47 +0300 [thread overview]
Message-ID: <20160606121747.GA3663@leon.nu> (raw)
In-Reply-To: <20160606063454.GP7477@leon.nu>
[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]
On Mon, Jun 06, 2016 at 09:34:54AM +0300, Leon Romanovsky wrote:
> On Sun, Jun 05, 2016 at 09:13:56PM +0100, Sudip Mukherjee wrote:
> > If the allocation of hsag fails we were just returning but stats was
> > not released.
> >
> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
It looks the same as Colin's patch which was sent a week ago.
http://marc.info/?l=linux-kernel&m=146480441931189&w=2
>
> > ---
> > drivers/infiniband/core/sysfs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
> > index fcf6f9c..8d8732c 100644
> > --- a/drivers/infiniband/core/sysfs.c
> > +++ b/drivers/infiniband/core/sysfs.c
> > @@ -906,7 +906,7 @@ static void setup_hw_stats(struct ib_device *device, struct ib_port *port,
> > sizeof(void *) * (stats->num_counters + 1),
> > GFP_KERNEL);
> > if (!hsag)
> > - return;
> > + goto err;
> >
> > ret = device->get_hw_stats(device, stats, port_num,
> > stats->num_counters);
> > --
> > 1.9.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-06 12:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-05 20:13 [PATCH 1/2] IB/sysfs: fix NULL dereference Sudip Mukherjee
2016-06-05 20:13 ` [PATCH 2/2] IB/sysfs: fix memory leak Sudip Mukherjee
2016-06-06 6:34 ` Leon Romanovsky
2016-06-06 12:17 ` Leon Romanovsky [this message]
2016-06-07 11:50 ` Doug Ledford
2016-06-06 6:30 ` [PATCH 1/2] IB/sysfs: fix NULL dereference Leon Romanovsky
2016-06-07 11:48 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606121747.GA3663@leon.nu \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox