From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753076AbcFFObT (ORCPT ); Mon, 6 Jun 2016 10:31:19 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58939 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752872AbcFFOaT (ORCPT ); Mon, 6 Jun 2016 10:30:19 -0400 Date: Mon, 6 Jun 2016 07:30:01 -0700 From: Greg KH To: jyoti singh Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, Jyoti Singh Subject: Re: [PATCH] char: Prefer pr_* instead of printk Message-ID: <20160606143001.GA4181@kroah.com> References: <1465051511-10758-1-git-send-email-jssengar92@gmail.com> <20160604163640.GA6559@kroah.com> <20160605150322.GB14267@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2016 at 11:44:07AM +0530, jyoti singh wrote: > yes sir, > I have written a tty driver module there i had used printk and pr_*. > it is working fine with both. That's not the answer to my question, did you test _this_ driver with _these_ changes? Or at least I think that was what my question was, I don't see it here in the context so I don't remember... greg k-h