From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752886AbcFFOkr (ORCPT <rfc822;w@1wt.eu>);
	Mon, 6 Jun 2016 10:40:47 -0400
Received: from vps0.lunn.ch ([178.209.37.122]:60498 "EHLO vps0.lunn.ch"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752047AbcFFOkp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 6 Jun 2016 10:40:45 -0400
Date: Mon, 6 Jun 2016 16:40:36 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Mario Limonciello <mario_limonciello@dell.com>
Cc: hayeswang@realtek.com, LKML <linux-kernel@vger.kernel.org>,
        Netdev <netdev@vger.kernel.org>, Linux USB <linux-usb@vger.kernel.org>,
        pali.rohar@gmail.com, anthony.wong@canonical.com,
        Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC
 address on RTL8153-AD
Message-ID: <20160606144036.GA30948@lunn.ch>
References: <1465222521-7217-1-git-send-email-mario_limonciello@dell.com>
 <1465222521-7217-2-git-send-email-mario_limonciello@dell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1465222521-7217-2-git-send-email-mario_limonciello@dell.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +	/* returns _AUXMAC_#AABBCCDDEEFF# */
> +	status = acpi_evaluate_object(NULL, "\\_SB.AMAC", NULL, &buffer);
> +	obj = (union acpi_object *)buffer.pointer;
> +	if (ACPI_SUCCESS(status)) {
> +		if (obj->type != ACPI_TYPE_BUFFER ||
> +		    obj->string.length != 0x17) {
> +			pr_warn("r8152: get_passthru_addr: Invalid buffer");

Please don't use pr_warn() when you can use the better alternatives
like dev_warn().

     Andrew