From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753051AbcFFOla (ORCPT ); Mon, 6 Jun 2016 10:41:30 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59229 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751778AbcFFOl3 (ORCPT ); Mon, 6 Jun 2016 10:41:29 -0400 Date: Mon, 6 Jun 2016 07:41:28 -0700 From: Greg KH To: Heikki Krogerus Cc: Pavel Machek , Guenter Roeck , Mathias Nyman , Felipe Balbi , Oliver Neukum , Rajaram R , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [RFC PATCHv2] usb: USB Type-C Connector Class Message-ID: <20160606144128.GC4758@kroah.com> References: <1463661894-22820-1-git-send-email-heikki.krogerus@linux.intel.com> <20160603202001.GB11253@amd> <20160606134509.GB11617@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160606134509.GB11617@kuha.fi.intel.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2016 at 04:45:09PM +0300, Heikki Krogerus wrote: > Hi, > > On Fri, Jun 03, 2016 at 10:20:01PM +0200, Pavel Machek wrote: > > On Thu 2016-05-19 15:44:54, Heikki Krogerus wrote: > > > The purpose of this class is to provide unified interface for user > > > space to get the status and basic information about USB Type-C > > > Connectors in the system, control data role swapping, and when USB PD > > > is available, also power role swapping and Alternate Modes. > > > > > > Signed-off-by: Heikki Krogerus > > > --- > > > drivers/usb/Kconfig | 2 + > > > drivers/usb/Makefile | 2 + > > > drivers/usb/type-c/Kconfig | 7 + > > > drivers/usb/type-c/Makefile | 1 + > > > drivers/usb/type-c/typec.c | 957 ++++++++++++++++++++++++++++++++++++++++++++ > > > > For consistency, should this be either type-c/type-c.c or > > typec/typec.c? > > For some reason I like to have the dash in the folder name, but I > don't like the idea that the port driver would be in form > type-c_something. I would prefer them to be named typec_something. Or > maybe just "something" and also name the typec.c maybe class.c or > core.c. > > Is this a big problem? I guess we could just name the folder "typec". > Guenter, whats your opinion? "typec" please.