From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752590AbcFFOuY (ORCPT ); Mon, 6 Jun 2016 10:50:24 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59412 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751595AbcFFOuW (ORCPT ); Mon, 6 Jun 2016 10:50:22 -0400 Date: Mon, 6 Jun 2016 07:50:21 -0700 From: Greg KH To: Mario_Limonciello@Dell.com Cc: hayeswang@realtek.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, pali.rohar@gmail.com, anthony.wong@canonical.com Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Message-ID: <20160606145021.GA6433@kroah.com> References: <1465222521-7217-1-git-send-email-mario_limonciello@dell.com> <20160606144009.GB4758@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2016 at 02:43:37PM +0000, Mario_Limonciello@Dell.com wrote: > > -----Original Message----- > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > Sent: Monday, June 6, 2016 9:40 AM > > To: Limonciello, Mario > > Cc: hayeswang@realtek.com; LKML ; Netdev > > ; Linux USB ; > > pali.rohar@gmail.com; anthony.wong@canonical.com > > Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC > > address on RTL8153-AD > > > > On Mon, Jun 06, 2016 at 09:15:20AM -0500, Mario Limonciello wrote: > > > Since this is a Realtek feature, I feel this shouldn't be moved into a platform > > > MAC address lookup. The code should only be run when the correct > > Realtek device > > > is plugged in. > > > > > > Changes from v2: > > > * Only apply to RTL8153-AD w/ eFuse pass through mac address pass thru > > > bit set. > > > * Drop matching DMI information on Dell. Although this is implemented > > on > > > Dell, this is a Realtek feature that may may be implemented on other > > > OEMs as well. > > > * Test that pass through MAC address is valid, fall back to HW address if > > > invalid. > > > * Don't track status of which device has MAC pass through activated. > > > - Expected experience is that if two docks (RTL8153-AD's w/ mac pass thru > > > bit set) were plugged in both should have MAC pass through activated. > > > > cover letters for single-patch submissions is overkill and confusing, > > please don't. > > I was trying to convey differences between versions of this patch, I'll avoid > that in the future and let the audience find them themselves. No, put them in the patch itself, under the --- line, like is documented to do so. Don't make people "find them themselves", if you do that, your patch will just be ignored. greg k-h