From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753159AbcFFOv4 (ORCPT ); Mon, 6 Jun 2016 10:51:56 -0400 Received: from mail.kernel.org ([198.145.29.136]:54328 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753082AbcFFOvz (ORCPT ); Mon, 6 Jun 2016 10:51:55 -0400 Date: Mon, 6 Jun 2016 11:51:48 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen Cc: linux-kernel@vger.kernel.org, jolsa@kernel.org, Andi Kleen Subject: Re: [PATCH] perf test: Ignore .scale and other special files Message-ID: <20160606145148.GC31477@kernel.org> References: <1465223766-29902-1-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465223766-29902-1-git-send-email-andi@firstfloor.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Jun 06, 2016 at 07:36:06AM -0700, Andi Kleen escreveu: > perf test tries to parse all entries in /sys/devices/cpu/events/. > Ignore the special entries like '.scale', which cannot be directly > parsed as an event. This patch assumes all files containing a '.' > are special and can be ignored. > +++ b/tools/perf/tests/parse-events.c > @@ -1783,8 +1783,8 @@ static int test_pmu_events(void) > - if (!strcmp(ent->d_name, ".") || > - !strcmp(ent->d_name, "..")) > + /* Names containing . are special and cannot be used directly */ > + if (strchr(ent->d_name, '.')) > continue; Ok, this is a more generic fix than the one I used here (adding: || strends(ent->d_name, ".scale"), I'll use yours, but this gets us to the following error: [root@jouet ~]# perf test -v 5 2>&1 | tail running test 49 'r1234/name=rawpmu/' running test 50 '4:0x6530160/name=numpmu/' running test 51 'L1-dcache-misses/name=cachepmu/' running test 0 'cpu/config=10,config1,config2=3,period=1000/u' running test 1 'cpu/config=1,name=krava/u,cpu/config=2/u' running test 2 'cpu/config=1,call-graph=fp,time,period=100000/,cpu/config=2,call-graph=no,time=0,period=2000/' failed to parse event 'topdown-total-slots:u,cpu/event=topdown-total-slots/u', err 1 test child finished with 1 ---- end ---- parse events tests: FAILED! [root@jouet ~]# cat /sys/devices/cpu/events/topdown-total-slots event=0x3c,umask=0x0,any=1[root@jouet ~]# [root@jouet ~]# [root@jouet ~]# cat /sys/devices/cpu/events/bus-cycles event=0x3c,umask=0x01 [root@jouet ~]# I.e seems to be bickering about a missing newline in the sysfs entry, will check the parser... - Arnaldo