From: Christoph Hellwig <hch@lst.de>
To: Shaun Tancheff <shaun.tancheff@seagate.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Jens Axboe <axboe@fb.com>,
Larry.Finger@lwfinger.net, bart.vanassche@sandisk.com,
drysdale@google.com
Subject: Re: kmemleak report after 9082e87bfbf8 ("block: remove struct bio_batch")
Date: Mon, 6 Jun 2016 19:27:18 +0200 [thread overview]
Message-ID: <20160606172718.GA30574@lst.de> (raw)
In-Reply-To: <CAJVOszD16vfES8e6NcanBJ7P4HHmp635Ln7VVVyraaPnm0jriA@mail.gmail.com>
On Mon, Jun 06, 2016 at 12:09:49PM -0500, Shaun Tancheff wrote:
> I'm pretty sure it is missing a bio_put() after submit_bio_wait().
>
> Please excuse the hack-y patch but I think you need to do something
> like this ...
> (Note tabs eaten by gmail).
Yeah, that makes sense - oddly enough submit_bio_wait doesn't do a
bio_put. Still not sure why I don't see the leaks after repeated
mkfs.xfs runs, though.
next prev parent reply other threads:[~2016-06-06 17:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 11:26 kmemleak report after 9082e87bfbf8 ("block: remove struct bio_batch") Catalin Marinas
2016-06-06 14:13 ` Christoph Hellwig
2016-06-06 16:12 ` Catalin Marinas
2016-06-06 17:09 ` Shaun Tancheff
2016-06-06 17:27 ` Christoph Hellwig [this message]
2016-06-06 17:35 ` Catalin Marinas
2016-06-06 18:15 ` Jens Axboe
2016-06-07 9:39 ` Catalin Marinas
2016-06-07 14:18 ` Larry Finger
2016-06-07 15:43 ` David Drysdale
2016-06-07 4:06 ` Larry Finger
2016-06-07 6:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606172718.GA30574@lst.de \
--to=hch@lst.de \
--cc=Larry.Finger@lwfinger.net \
--cc=axboe@fb.com \
--cc=bart.vanassche@sandisk.com \
--cc=catalin.marinas@arm.com \
--cc=drysdale@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaun.tancheff@seagate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox