From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753356AbcFGE3C (ORCPT ); Tue, 7 Jun 2016 00:29:02 -0400 Received: from muru.com ([72.249.23.125]:55553 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751377AbcFGE27 (ORCPT ); Tue, 7 Jun 2016 00:28:59 -0400 Date: Mon, 6 Jun 2016 21:28:54 -0700 From: Tony Lindgren To: Nishanth Menon Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Russell King , Santosh Shilimkar , Grygorii Strashko , Lokesh Vutla , linux-kernel@vger.kernel.org, Tero Kristo , Murali Karicheri , Bill Mills , linux-omap@vger.kernel.org Subject: Re: [PATCH] ARM: Keystone: Introduce Kconfig option to compile in typical Keystone features Message-ID: <20160607042853.GA22406@atomide.com> References: <1464816714-3900-1-git-send-email-nm@ti.com> <3593753.UuDg5ybrvm@wuerfel> <574F6674.3010100@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <574F6674.3010100@ti.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Nishanth Menon [160601 15:51]: > On 06/01/2016 05:31 PM, Arnd Bergmann wrote: > > On Wednesday, June 1, 2016 4:31:54 PM CEST Nishanth Menon wrote: > >> > >> Hence the "KEYSTONE_TYPICAL" option is designed similar to commit 8d9166b519fd > >> ("omap2/3/4: Add Kconfig option to compile in typical omap features") > >> that can be enabled for most boards keystone platforms > >> without needing to rediscover these in defconfig all over again - > >> examples include multi_v7_defconfig base and optimizations done on top > >> of them for keystone platform. > > > > I'd rather remove the option for OMAP as well, it doesn't really fit in with > > how we do things for other platforms, and selecting a lot of other Kconfig > > symbols tends to cause circular dependencies. > > Hmm, fair enough -> adding Tony as well if he sees an problem with > dropping ARCH_OMAP2PLUS_TYPICAL. Yes there's a problem. Removing that is going to make all the custom .config files unbootable almost certainly. Just search around on issues related to not having REGULATOR_FIXED_VOLTAGE selected. I agree we should not force select things though. And the I2C selection at least is wrong, we can have PMICs that are not on I2C bus. Anybody got better ideas what we should do to make the configuration options more intuitive? Regards, Tony