From: Peter Zijlstra <peterz@infradead.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Julien Desfossez <jdesfossez@efficios.com>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] sched: encapsulate priority changes in a sched_set_prio static function
Date: Tue, 7 Jun 2016 09:11:45 +0200 [thread overview]
Message-ID: <20160607071144.GK30909@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1547310235.29814.1465249672015.JavaMail.zimbra@efficios.com>
On Mon, Jun 06, 2016 at 09:47:52PM +0000, Mathieu Desnoyers wrote:
> >> +++ b/kernel/sched/core.c
> >> @@ -2230,6 +2230,11 @@ int sysctl_schedstats(struct ctl_table *table, int write,
> >> #endif
> >> #endif
> >>
> >> +static void sched_set_prio(struct task_struct *p, int prio)
> >> +{
> >> + p->prio = prio;
> >> +}
Urgh; so there's a bunch of patches to the PI code that I've been
ignoring that'll completely break all this.
Let me dig them up and get this all sorted.
Basically, looking at @prio is broken.
prev parent reply other threads:[~2016-06-07 7:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 15:16 [RFC PATCH 1/2] sched: encapsulate priority changes in a sched_set_prio static function Julien Desfossez
2016-05-27 15:16 ` [RFC PATCH 2/2] tracing: add sched_set_prio tracepoint Julien Desfossez
2016-05-30 13:18 ` Mathieu Desnoyers
2016-06-06 19:52 ` Mathieu Desnoyers
2016-06-06 21:03 ` Peter Zijlstra
2016-06-08 0:18 ` Daniel Bristot de Oliveira
2016-05-30 13:18 ` [RFC PATCH 1/2] sched: encapsulate priority changes in a sched_set_prio static function Mathieu Desnoyers
2016-06-06 21:47 ` Mathieu Desnoyers
2016-06-07 7:11 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607071144.GK30909@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=jdesfossez@efficios.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox