From: Vinod Koul <vinod.koul@intel.com>
To: Eric Anholt <eric@anholt.net>
Cc: linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>,
dmaengine@vger.kernel.org
Subject: Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked.
Date: Tue, 7 Jun 2016 12:51:21 +0530 [thread overview]
Message-ID: <20160607072121.GM16910@localhost> (raw)
In-Reply-To: <87k2i1leap.fsf@eliezer.anholt.net>
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
On Mon, Jun 06, 2016 at 11:10:38PM -0700, Eric Anholt wrote:
> >> >> - if (ret == DMA_COMPLETE || !txstate)
> >> >> + if (ret == DMA_COMPLETE)
> >> >
> >> > Why do you change this? txstate can be NULL, so no point calculating reside
> >> > for those cases
> >>
> >> The point was to go into the "Calculate where we're at in our current
> >> DMA (if the current DMA is the one we're asking about status for)" path,
> >> so that we could note when the DMA is complete even when there's no
> >> txstate passed in.
> >
> > Can you explain what you mean by current DMA!
> >
> > The claulation is always done for 'descriptor' represnted by the cookie. So
> > it doesnt not matter...!
>
> By current I mean the current descriptor that has been submitted to the
> hardware, in bcm2835_chan->desc.
As I said, you calculate for the descriptor respresnted by cookie and
not the one getting processed!
--
~Vinod
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-07 7:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 2:29 [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked Eric Anholt
2016-06-06 4:26 ` Vinod Koul
2016-06-06 17:33 ` Eric Anholt
2016-06-07 5:24 ` Vinod Koul
2016-06-07 6:10 ` Eric Anholt
2016-06-07 7:21 ` Vinod Koul [this message]
2016-06-07 20:56 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607072121.GM16910@localhost \
--to=vinod.koul@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=eric@anholt.net \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox