From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754028AbcFGHqn (ORCPT ); Tue, 7 Jun 2016 03:46:43 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:59656 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751768AbcFGHql (ORCPT ); Tue, 7 Jun 2016 03:46:41 -0400 Date: Tue, 7 Jun 2016 09:46:33 +0200 From: Pavel Machek To: dbasehore@chromium.org Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rjw@rjwysocki.net, len.brown@intel.com, tglx@linutronix.de Subject: Re: [PATCH 0/5] Add suspend-to-idle validation for Intel SoCs Message-ID: <20160607074632.GA13858@amd> References: <1464842009-21789-1-git-send-email-dbasehore@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464842009-21789-1-git-send-email-dbasehore@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2016-06-01 21:33:24, dbasehore@chromium.org wrote: > From: Derek Basehore > > This patch set adds support for catching errors when entering freeze > on Intel Skylake SoCs. Support for this can be added to newer SoCs in > later patches. > > Verification is done by waking up the CPU once every X (default 10) > seconds to check the residency of S0ix. This can't be verified before > attempting to enter S0ix through mwait, so we have to repeatedly > verify entry into that state. Successfully entering S0ix is no > guarantee that it will be entered on the next attempt, so we have to > schedule another check. This has a minimal power impact of <1% of the > total system power on our systems. Dunno. Should this be protected with something like CONFIG_TEST_SLEEP? People probably don't want this for production... -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html