From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932283AbcFGJY1 (ORCPT ); Tue, 7 Jun 2016 05:24:27 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:35119 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932097AbcFGJYZ (ORCPT ); Tue, 7 Jun 2016 05:24:25 -0400 Date: Tue, 7 Jun 2016 10:24:56 +0100 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, balbi@kernel.org, kernel@stlinux.com, srinivas.kandagatla@gmail.com, linux-usb@vger.kernel.org, kishon@ti.com, p.zabel@pengutronix.de, gregkh@linuxfoundation.org Subject: Re: [STLinux Kernel] [PATCH 0/7] reset: Consumers to explicitly request 'exclusive' or 'shared' lines Message-ID: <20160607092456.GE18047@dell> References: <20160606155655.10860-1-lee.jones@linaro.org> <20160607084208.GB22960@griffinp-ThinkPad-X1-Carbon-2nd> <20160607091543.GC18047@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160607091543.GC18047@dell> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 07 Jun 2016, Lee Jones wrote: > On Tue, 07 Jun 2016, Peter Griffin wrote: > > > Hi, > > > > On Mon, 06 Jun 2016, Lee Jones wrote: > > > > > Phasing out generic reset line requests enables us to make some better > > > decisions on when and how to (de)assert said lines. If an 'exclusive' > > > line is requested, we know a device *requires* a reset and that it's > > > preferable to act upon a request right away. However, if a 'shared' > > > reset line is requested, we can reasonably assume sure that placing a > > > device into reset isn't a hard requirement, but probably a measure to > > > save power and is thus able to cope with not being asserted if another > > > device is still in use. > > > > > > In order allow gentle adoption and not to forcing all consumers to > > > move to the API immediately, causing administration headache between > > > subsystems, this patch adds some temporary stand-in shim-calls. This > > > will ease the burden at merge time and allow subsystems to migrate over > > > to the new API in a more realistic time-frame. > > > > Is the intention that this series will be taken into the next -rc? > > > > As the introduction of shared resets in reset subsystem has caused regressions > > on STi platforms. > > Yes, which is why it has a Fixes: tag. Ah wait. I thought this was the shared-memory patch. More haste, less speed and all that. I guess it should really go into the -rcs, yes. Since Hans' patch actually breaks a lot of devices. I'm pretty surprised a patch capable of this much damage was actually accepted to be honest. A better approach would have been to issue a warning, but keep the semantics the same for at least a couple of releases. However, I guess the damage has been done now, so let's do what we can do fix it. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog