From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755180AbcFGMnE (ORCPT ); Tue, 7 Jun 2016 08:43:04 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:54937 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753412AbcFGMnB (ORCPT ); Tue, 7 Jun 2016 08:43:01 -0400 Date: Tue, 7 Jun 2016 05:42:59 -0700 From: Christoph Hellwig To: Sagi Grimberg Cc: Sudip Mukherjee , Doug Ledford , Sean Hefty , Hal Rosenstock , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, leon@kernel.org Subject: Re: [PATCH v2] IB/core: remove dead code Message-ID: <20160607124259.GA3906@infradead.org> References: <1465247706-4418-1-git-send-email-sudipm.mukherjee@gmail.com> <5756C0E0.7090303@lightbits.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5756C0E0.7090303@lightbits.io> User-Agent: Mutt/1.5.24 (2015-08-30) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 07, 2016 at 03:41:04PM +0300, Sagi Grimberg wrote: > Actually it looks like the data-integrity insert/strip operation > (where protection sg list does not exist) is broken. > > It looks that the protection scatterlist should be done only if > prot_sg_count was provided... > > I don't have access to mlx5 devices at the moment (still waiting > to get some...) I've reported the brokenness in the existing iSER code when I started working on signature MR support in the generic API. As no one helped managed to figure out the issue or how it should operate I clone the existing semantics, even given I knew they are broken.