From: Mel Gorman <mgorman@techsingularity.net>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org,
Matt Fleming <matt@codeblueprint.co.uk>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 1/2] sched/debug: fix /proc/sched_debug regression
Date: Tue, 7 Jun 2016 14:47:57 +0100 [thread overview]
Message-ID: <20160607134757.GC2527@techsingularity.net> (raw)
In-Reply-To: <bcda7c2790cf2ccbe586a28c02dd7b6fe7749a2b.1464994423.git.jpoimboe@redhat.com>
On Fri, Jun 03, 2016 at 05:58:40PM -0500, Josh Poimboeuf wrote:
> Commit cb2517653fcc ("sched/debug: Make schedstats a runtime tunable
> that is disabled by default") introduced a bug when CONFIG_SCHEDSTATS is
> enabled and the runtime tunable is disabled (which is the default). The
> wait-time, sum-exec, and sum-sleep fields are missing from the
> /proc/sched_debug file in the runnable_tasks section.
>
I take it that this breaks userspace parsing?
> Fix it with a new schedstat_val() macro which returns the field value
> when schedstats is enabled and zero otherwise. The macro works with
> both SCHEDSTATS and !SCHEDSTATS. I put the macro in stats.h since it
> might end up being useful in other places.
>
> Fixes: cb2517653fcc ("sched/debug: Make schedstats a runtime tunable that is disabled by default")
> Cc: stable@vger.kernel.org
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2016-06-07 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 22:58 [PATCH v2 0/2] sched/debug: schedstats bug fix and improvement Josh Poimboeuf
2016-06-03 22:58 ` [PATCH v2 1/2] sched/debug: fix /proc/sched_debug regression Josh Poimboeuf
2016-06-07 13:47 ` Mel Gorman [this message]
2016-06-07 17:58 ` Josh Poimboeuf
2016-06-08 14:20 ` [tip:sched/core] sched/debug: Fix " tip-bot for Josh Poimboeuf
2016-06-03 22:58 ` [PATCH v2 2/2] sched/debug: always show nr_migrations Josh Poimboeuf
2016-06-07 13:48 ` Mel Gorman
2016-06-08 14:21 ` [tip:sched/core] sched/debug: Always show 'nr_migrations' tip-bot for Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607134757.GC2527@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox