From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754462AbcFGOBS (ORCPT ); Tue, 7 Jun 2016 10:01:18 -0400 Received: from mga09.intel.com ([134.134.136.24]:58290 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753862AbcFGOBO (ORCPT ); Tue, 7 Jun 2016 10:01:14 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,433,1459839600"; d="scan'208";a="970623567" Date: Tue, 7 Jun 2016 17:01:03 +0300 From: Jarkko Sakkinen To: Ed Swierk Cc: tpmdd-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH v3 2/4] tpm: Add optional logging of TPM command durations Message-ID: <20160607140103.GF3855@intel.com> References: <1465270649-22498-1-git-send-email-eswierk@skyportsystems.com> <1465270649-22498-3-git-send-email-eswierk@skyportsystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465270649-22498-3-git-send-email-eswierk@skyportsystems.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2016 at 08:37:27PM -0700, Ed Swierk wrote: > Some TPMs violate their own advertised command durations. This is much > easier to debug with data about how long each command actually takes > to complete. Add debug messages that can be enabled by running > > echo -n 'module tpm +p' >/sys/kernel/debug/dynamic_debug/control > > on a kernel configured with DYNAMIC_DEBUG=y. > > Signed-off-by: Ed Swierk Reviewed-by: Jarkko Sakkinen > --- > drivers/char/tpm/tpm-interface.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c > index c50637d..cc1e5bc 100644 > --- a/drivers/char/tpm/tpm-interface.c > +++ b/drivers/char/tpm/tpm-interface.c > @@ -333,13 +333,14 @@ ssize_t tpm_transmit(struct tpm_chip *chip, const char *buf, > { > ssize_t rc; > u32 count, ordinal; > - unsigned long stop; > + unsigned long start, stop; > > if (bufsiz > TPM_BUFSIZE) > bufsiz = TPM_BUFSIZE; > > count = be32_to_cpu(*((__be32 *) (buf + 2))); > ordinal = be32_to_cpu(*((__be32 *) (buf + 6))); > + dev_dbg(chip->pdev, "starting command %d count %d\n", ordinal, count); > if (count == 0) > return -ENODATA; > if (count > bufsiz) { > @@ -360,18 +361,24 @@ ssize_t tpm_transmit(struct tpm_chip *chip, const char *buf, > if (chip->vendor.irq) > goto out_recv; > > + start = jiffies; > if (chip->flags & TPM_CHIP_FLAG_TPM2) > - stop = jiffies + tpm2_calc_ordinal_duration(chip, ordinal); > + stop = start + tpm2_calc_ordinal_duration(chip, ordinal); > else > - stop = jiffies + tpm_calc_ordinal_duration(chip, ordinal); > + stop = start + tpm_calc_ordinal_duration(chip, ordinal); > do { > u8 status = chip->ops->status(chip); > if ((status & chip->ops->req_complete_mask) == > - chip->ops->req_complete_val) > + chip->ops->req_complete_val) { > + dev_dbg(chip->pdev, "completed command %d in %d ms\n", > + ordinal, jiffies_to_msecs(jiffies - start)); > goto out_recv; > + } > > if (chip->ops->req_canceled(chip, status)) { > dev_err(chip->pdev, "Operation Canceled\n"); > + dev_dbg(chip->pdev, "canceled command %d after %d ms\n", > + ordinal, jiffies_to_msecs(jiffies - start)); > rc = -ECANCELED; > goto out; > } > @@ -382,6 +389,8 @@ ssize_t tpm_transmit(struct tpm_chip *chip, const char *buf, > > chip->ops->cancel(chip); > dev_err(chip->pdev, "Operation Timed out\n"); > + dev_dbg(chip->pdev, "command %d timed out after %d ms\n", ordinal, > + jiffies_to_msecs(jiffies - start)); > rc = -ETIME; > goto out; > > -- > 1.9.1 > > > ------------------------------------------------------------------------------ > What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic > patterns at an interface-level. Reveals which users, apps, and protocols are > consuming the most bandwidth. Provides multi-vendor support for NetFlow, > J-Flow, sFlow and other flows. Make informed decisions using capacity > planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e > _______________________________________________ > tpmdd-devel mailing list > tpmdd-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/tpmdd-devel /Jarkko