From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161600AbcFGQ6Y (ORCPT ); Tue, 7 Jun 2016 12:58:24 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:51697 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161308AbcFGQ6V (ORCPT ); Tue, 7 Jun 2016 12:58:21 -0400 Date: Tue, 7 Jun 2016 09:57:58 -0700 From: Guenter Roeck To: Heikki Krogerus Cc: Oliver Neukum , Andy Shevchenko , Rajaram R , Felipe Balbi , Mathias Nyman , Greg KH , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [RFC PATCHv2] usb: USB Type-C Connector Class Message-ID: <20160607165758.GA4014@roeck-us.net> References: <1463661894-22820-1-git-send-email-heikki.krogerus@linux.intel.com> <1464773169.4051.8.camel@suse.com> <20160601232926.GA8463@roeck-us.net> <20160602101853.GC25305@kuha.fi.intel.com> <20160602161219.GA24772@roeck-us.net> <20160603132140.GB6305@kuha.fi.intel.com> <57518B7A.1030508@roeck-us.net> <20160603151746.GC6305@kuha.fi.intel.com> <20160603183927.GA12659@roeck-us.net> <20160606132808.GA11617@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160606132808.GA11617@kuha.fi.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2016 at 04:28:08PM +0300, Heikki Krogerus wrote: [ ... ] > > I would prefer lower case letters. I don't know the SIDs there are at > them moment, other then Display Port. Do you know them? > SIDs: 0xff00 - power delivery 0xff01 - displayport 0xff02 - MHL 0xff03 - Thunderbolt 3 (if I recall correctly) VIDs: Can obviously be anything. I have seen 0x05ac - Apple 0x18d1 - Google > I don't think we can ever guarantee that in every case we will be able > to provide a human readable name for the alternate modes if they are > vendor defined. We will then potentially still have the names in two > different forms: "usbc0.displayport" and "usbc0.svid:xxxx". Is that > something acceptable to everybody? > > I guess if it's not, then to only way to go forward would be to always > just use the svid in the name. > I think we should just use the svid. > > > > Also, do we at some point need to standardize the ABI for the standard > > > > alternate modes such as DisplayPort (if there are any - again I am not > > > > there yet) ? > > > > > > I don't have an answer to that. > > > > > Ok, I'll look into it as I proceed with my implementation. > > > > > > > > > > Sounds good to me. Many other subsystems do the same, ie create the subsystem > > > > device(s) during registration with the subsystem, so this is in line with other > > > > kernel code. > > > > > > > > Should I send you a follow-up patch on top of yours ? > > > > > > Sure. I'm a little bit stuck with an other tasks, so let's keep this > > > thing rolling. > > > > > See below. > > Thanks. I pushed it to my work branch for this class: > > https://github.com/krohei/linux/commits/typec_class > > There are still a few open questions, but I'm in any case going to > start polishing the driver. I think the other attributes are more or > less decided, excluding the alternate modes. > Sounds good. Thanks, Guenter