From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422816AbcFGSH6 (ORCPT ); Tue, 7 Jun 2016 14:07:58 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:3222 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161534AbcFGSH5 (ORCPT ); Tue, 7 Jun 2016 14:07:57 -0400 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: heiko.carstens@de.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Tue, 7 Jun 2016 20:07:48 +0200 From: Heiko Carstens To: Kees Cook Cc: Ingo Molnar , Martin Schwidefsky , LKML Subject: Re: [PATCH 0/2] Proper ro_after_init implementation on s390 References: <201606071207.u57C5SK3003539@mx0a-001b2d01.pphosted.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16060718-0004-0000-0000-0000032D356A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16060718-0005-0000-0000-00001A3AE827 Message-Id: <20160607180748.GA4280@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-07_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606070201 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 07, 2016 at 08:49:14AM -0700, Kees Cook wrote: > > Heiko Carstens (2): > > vmlinux.lds.h: allow arch specific handling of ro_after_init data section > > s390/mm: add proper __ro_after_init support > > > > arch/s390/include/asm/cache.h | 3 --- > > arch/s390/include/asm/sections.h | 1 + > > arch/s390/kernel/vmlinux.lds.S | 12 +++++++++++- > > arch/s390/mm/init.c | 7 ++++--- > > arch/s390/mm/vmem.c | 7 +++---- > > include/asm-generic/vmlinux.lds.h | 10 +++++++++- > > 6 files changed, 28 insertions(+), 12 deletions(-) > > Awesome! This looks great to me! Have you had a chance to look through > any of the arch/s390/ __init code for variables that should be marked > __ro_after_init? Not yet, and actually this I'm a bit reluctant to do that, since any wrong annotation will lead to kernel crashes sooner or later ;) However I'll look into this as well. > Reviewed-by: Kees Cook Thanks! I add that to both patches. (sorry for the broken threading; one of the outgoing mail servers rewrote all Message-Id headers)