From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
To: Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Matan Barak <matanb@mellanox.com>,
Haggai Eran <haggaie@mellanox.com>,
Erez Shitrit <erezsh@mellanox.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Tejun Heo <tj@kernel.org>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC] IB/core: Remove create_workqueue
Date: Tue, 7 Jun 2016 23:40:06 +0530 [thread overview]
Message-ID: <20160607181005.GA6233@Karyakshetra> (raw)
alloc_workqueue replaces deprecated create_workqueue().
A dedicated workqueue has been used since cm.wq has workitem
&cm_id_priv->timewait_info->work.work (maps to cm_work_handler) is
involved in normal device operation. When a cm mad is received, it is
queued to a cm workqueue for processing. The queued work item references
the port and device on which the mad was received. WQ_MEM_RECLAIM has been
set to ensure forward progress under memory pressure.
Since there are only a fixed number of work
items, explicit concurrency limit is unnecessary here.
Is the workqueue being used on a memory reclaim path?
Does it require WQ_MEM_RECLAIM?
Thanks.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/core/cm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
index 1d92e09..e335d0b 100644
--- a/drivers/infiniband/core/cm.c
+++ b/drivers/infiniband/core/cm.c
@@ -4004,7 +4004,7 @@ static int __init ib_cm_init(void)
goto error1;
}
- cm.wq = create_workqueue("ib_cm");
+ cm.wq = alloc_workqueue("ib_cm", WQ_MEM_RECLAIM, 0);
if (!cm.wq) {
ret = -ENOMEM;
goto error2;
--
2.1.4
reply other threads:[~2016-06-07 18:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607181005.GA6233@Karyakshetra \
--to=bhaktipriya96@gmail.com \
--cc=bart.vanassche@sandisk.com \
--cc=dledford@redhat.com \
--cc=erezsh@mellanox.com \
--cc=haggaie@mellanox.com \
--cc=hal.rosenstock@gmail.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=sean.hefty@intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox