From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161833AbcFGT4Y (ORCPT ); Tue, 7 Jun 2016 15:56:24 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:33705 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161743AbcFGT4W (ORCPT ); Tue, 7 Jun 2016 15:56:22 -0400 Date: Tue, 7 Jun 2016 12:56:17 -0700 From: Bjorn Andersson To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, maxime.coquelin@st.com, patrice.chotard@st.com, srinivas.kandagatla@gmail.com, vinod.koul@intel.com, arnaud.pouliquen@st.com, arnd@arndb.de, lee.jones@linaro.org, dmaengine@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 01/18] remoteproc: make rsc table support optional Message-ID: <20160607195617.GI1256@tuxbot> References: <1465316352-20691-1-git-send-email-peter.griffin@linaro.org> <1465316352-20691-2-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465316352-20691-2-git-send-email-peter.griffin@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 07 Jun 09:18 PDT 2016, Peter Griffin wrote: > Some firmware and rproc drivers such as slim core don't have a > resource table. To avoid having to fudge an empty table > in the rproc driver this patch introduces a new has_rsctable > flag. rproc drivers which don't require a rsc table can set > this flag to false, and it avoids doing the initial async > firmware load in rproc_add_virtio_devices() to parse the > rsc table during rproc_add(), and also optimises rproc_fw_boot() > code path to avoid unnecessary rsc table processing of an > empty table. > > Signed-off-by: Peter Griffin Hi Peter, Thanks for the patch. I do however dislike the amount of conditionals already in these code paths, so I'm not in favour of adding more. Please revert back to providing a dummy table from your driver and let's handle this topic separate of this series. Regards, Bjorn