Re: [PATCH 2/4] dell-wmi: Sort WMI event codes and update comments

Pali Rohár
2016-06-08T19:57:32Z

[-- Attachment #1: Type: Text/Plain, Size: 1131 bytes --]

On Wednesday 08 June 2016 21:48:24 Darren Hart wrote:
> On Wed, Jun 08, 2016 at 12:03:24AM +0200, Pali Rohár wrote:
> > On Thursday 02 June 2016 12:41:42 Michał Kępień wrote:
> > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > >
> > > My guess is that Darren won't let you off without at least a
> > > short commit message.
> >
> > I have no idea what else to write. I think that description is
> > enough.
>
> There is always something. For example, why? See
> Documentation/SubmittingPatches section "14) The canonical patch
> format" for an explanation.
>
> "Traceability" of changes is important. If it's worth preparing the
> patch, it's worth documenting why.

In my opinion current description is enough and cover everything what
this patch is doing. I think it is clear from my description what this
patch is doing and so it is documented.

But if it is not clear and something is missing, let me know or show
what is wrong and how you change it... It is just my assumption that
"Sort WMI event codes and update comments" is clear...

--
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]