From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755396AbcFHCFb (ORCPT ); Tue, 7 Jun 2016 22:05:31 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:34937 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752341AbcFHCFa (ORCPT ); Tue, 7 Jun 2016 22:05:30 -0400 Date: Wed, 8 Jun 2016 10:05:25 +0800 From: Minfei Huang To: keith.busch@intel.com, axboe@fb.com, gpiccoli@linux.vnet.ibm.com, sagi@grimberg.me Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] Use MACRO UINT_MAX instead of actual value Message-ID: <20160608020525.GA16012@MinfeideMacBook-Pro.local> References: <1463471921-20261-1-git-send-email-mnghuan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463471921-20261-1-git-send-email-mnghuan@gmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Any comment is appreciate. Thanks Minfei On 05/17/16 at 03:58P, Minfei Huang wrote: > It's more elegant to use MACRO UINT_MAX to represent the max value of > type unsigned int. So replace the actual value by using this MACRO. > > Signed-off-by: Minfei Huang > --- > v1: > - fix typo > --- > drivers/nvme/host/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index 643f457..2c0bb13 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -597,7 +597,7 @@ static void nvme_config_discard(struct nvme_ns *ns) > > ns->queue->limits.discard_alignment = logical_block_size; > ns->queue->limits.discard_granularity = logical_block_size; > - blk_queue_max_discard_sectors(ns->queue, 0xffffffff); > + blk_queue_max_discard_sectors(ns->queue, UINT_MAX); > queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, ns->queue); > } > > -- > 2.6.3 >